Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

Updating pod predownload to default for every pod update. #33

Closed
shshalom opened this issue Aug 15, 2016 · 8 comments
Closed

Updating pod predownload to default for every pod update. #33

shshalom opened this issue Aug 15, 2016 · 8 comments

Comments

@shshalom
Copy link

Hey,
I know this library is in beta but I still want to use it.
It seems that every time I need to update my pod file I have to point out the location for my font file, which then takes some time until it regenerate the Icon class, more than that if I'm doing plain
pod update it installs Iconic with the default Icon class and removes mine..

Is there a better workflow for this?

@dzenbot
Copy link

dzenbot commented Aug 15, 2016

Hey there, thanks for trying it out.
Once you've installed Iconic with your own icon font (by assigning a font path like described in the README), you won't need to update it anymore, unless the font file changed. Calling pod install for adding new pods should not override the previous installation with your custom font.

@shshalom
Copy link
Author

And that exactly what I've done, but the actual outcome was as I described before.
My situation is as follows: I started a new project and I'm looking into different components, adding and removing pods, thus I get to use pod install and update quite a lot.
Since Iconic was one of my first libs I added to my project, I found my self installing and updating pods while assigning a font path every time, otherwise it generate and installs the default Icon class.

Any suggestions?
Thanks.

@dzenbot
Copy link

dzenbot commented Aug 15, 2016

This was a real concern for my use case too, and I though I had it fixed.
I will try to reproduce our use case, and see if there's something we can do about it.

The thing is, to be able to assign a dynamic file path for the library to do all the Swift generation, I used Cocoapod's environment variable but that feature wasn't really meant to do this sorts of things. I wonder if there is a better way.

@shshalom
Copy link
Author

For the time being my "solution" for this issue is to embed Iconic inside my project and removing it from the PodFile. I hope that this could be resolve soon so I could use the pod version.

@dzenbot
Copy link

dzenbot commented Aug 15, 2016

Definitely. Will keep this issue alive and see if I can fix it, since it could impact a lot of users.
Just curious, what icon font are you using? A custom one?

@shshalom
Copy link
Author

Yes, and I just stated another problem which is related to the usage of custom font in issue #34

@dzenbot
Copy link

dzenbot commented Oct 4, 2016

There has been many improvements added in #55 which should have fixed this issue. Please re-open if the issue persists.

@dzenbot dzenbot closed this as completed Oct 4, 2016
@shshalom
Copy link
Author

shshalom commented Oct 5, 2016

Great, will do.

dzenbot pushed a commit that referenced this issue Oct 22, 2016
dzenbot pushed a commit that referenced this issue Oct 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants