Saying 'hi', also opendbc

[rusefillc]

I am using this issue to start a dialog if that's OK 👍

Since you've moved BMW DBC files so much forward have you tried PRing anything into upstream https://github.com/commaai/opendbc? Is there any drama or else in terms of them not accepting BMW contributions etc?

I myself play with E65 which seems to overlap a lot see https://rusefi.com/forum/viewtopic.php?f=2&t=2241

[dzid26]

There was no drama, but they may have changed the stance now.

It added there most of the things needed by openpilot, so I was 50:50 thinking they would merge it.
I PR'ed there for people to have easier way to find it. I am sure it causes a bit of confusion for people thinking they could run Openpilot easily with their BMW.
In theory Openpilot could provide longitudinal Control (adaptive cruise control) for e90s without any extra hardware, so I guess that could be the rationale for adding it to their repo.

Nice efforts for E65.

[dzid26]

I could try to request PR again.

[rusefillc]

Yes please PR some or all of https://github.com/dzid26/opendbc-BMW-E8x-E9x changes upstream

also can you merge/rebase https://github.com/commaai/opendbc changes into your fork to reduce diversion between fork and upstream?

eventually we would also want to PR and the open question is how not to duplicate effort and where to PR to reduce or avoid merge conflicts.

[dzid26]

I submitted the PR.

I guess comma's opendbc repo could be the main avenue if they merge without problems.

I think it would be best anyway to watch each other's GitHub repos for any changes to avoid work duplicates.

Also, my general "worries" are that:

1. Possible conflicts between E65 and E90, etc. Maybe they should be separate files and overlaps could be merged manually.
2. Different tools provide slightly different dbc and e.g. cabana or kvaser have quite relaxed parsing, while CANdb++ is very strict. It's best to at least open the file with CANdb++ to check for errors before submitting.

[rusefillc]

Thank you @dzid26 !

From your past experience what's your prognosis on commaai/opendbc#572 merge? :)

[dzid26]

I did it just once, so I am not sure.
Let's see.

[dzid26]

They've updated quickly.

[rusefillc]

Sweeeeeeeeeeeeeeeeet

You probably know that you need to refresh your fork now

[rusefillc]

@HeinrichG-V12 welcome to our little chat issue :)

I assume that @dzid26 has an E89

[rusefillc]

PS: @dzid26 is your Z4 manual or auto?

[dzid26]

I updated master branch as well.
I have E82 DCT actually.

[rusefillc]

DCT very very interesting :) so for instance would you be interested in
https://github.com/HeinrichG-V12/E65_ReverseEngineering/blob/main/docs/0x0BA.md which has more than
https://github.com/commaai/opendbc/blob/a604b15617a1fcad914f10b7f4430dbcf080708a/bmw_e9x_e8x.dbc#L124 or is that just not the area of your interest?

what are your primary areas of interest? :)

[dzid26]

Probably nothing at the moment. Busy with other things.

I was doing this mainly to interface with openpilot's speed control. And then a bit more for finding differences between M/non-M modules versions.

Maybe worth trying to search for currently active people on spoolstreet forum. https://www.spoolstreet.com/forums/coding-programming-retrofits.136/ Few of them out there do tunes and retrofits that involve CAN deciphering or firmware disassembly.