Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ㄹ 종성과 -(으)로 미지원 #6

Open
kjoonlee opened this issue Oct 17, 2022 · 2 comments · May be fixed by #7
Open

ㄹ 종성과 -(으)로 미지원 #6

kjoonlee opened this issue Oct 17, 2022 · 2 comments · May be fixed by #7

Comments

@kjoonlee
Copy link

안녕하세요, index.js 편집 후 “강물”에 대해 테스트를 돌려봤더니 fail이 떴습니다.

리을 종성과 -(으)로 조사가 만났을 때의 케이스도 추가가 가능하다면 좋겠습니다.

		assert.deepEqual(
			Josa.c('강물', '으로/로'),
			'로',
			"Josa.c('강물', '로')"
		);
@kjoonlee
Copy link
Author

kjoonlee commented Oct 17, 2022

https://github.com/e-/Josa.js/blob/master/josa.js#L44

받침 검사를 0xAC00 뺄셈 후 mod 28 검사를 하는 것과 비슷하게 0xAC08 뺄셈 후 mod 28 검사를 하시면 ㄹ 받침 추출 가능하실 것 같습니다.

아니면 0xAC00 뺄셈 후 mod 28 검사값이 8일 경우를 체크하실 수도 있고요.

@kjoonlee
Copy link
Author

#7 만들어보았습니다. (GitHub 초보인 점 양해 부탁드립니다.)

@kjoonlee kjoonlee linked a pull request Oct 27, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant