branch_properties key "number" exists?

[mcyc]

I don't think values associated with the key "number" was typically generated for branch_properties. This is an issue when it comes to executing the following line:

FilFinder/fil_finder/length.py

Line 600 in 81b6012

branch_properties["number"][n] -= 1

Note: the "number" values are not a part of the branch_properties returned by init_lengths():

FilFinder/fil_finder/length.py

Line 127 in 81b6012

def init_lengths(labelisofil, filbranches, array_offsets, img):

[e-koch]

Hi @mcyc -- You're right, and I think the issue is that init_lengths was never being used on its own. branch_properties['number'] is getting set after calling init_lengths: https://github.com/e-koch/FilFinder/blob/master/fil_finder/filament.py#L264 (there's a similar line in the old fil_finder_2D). Setting the number of branches in init_lengths does make more sense.

Is this causing an error for you when running FilFinder2D?

[mcyc]

I haven't tried it with FilFinder2d, but it did cause me an error when I tried to run prune_graph with my own wrapper. Specifically, I run into an error when the 'criteria'

FilFinder/fil_finder/length.py

Line 590 in 81b6012

if criteria:

is true. This typically happens when the length_thresh parameter has a none-zero value.

[e-koch]

Added a fix in #47