Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#247 and removed FACT #248

Merged
merged 6 commits into from
May 19, 2022
Merged

#247 and removed FACT #248

merged 6 commits into from
May 19, 2022

Conversation

m-1-k-3
Copy link
Member

@m-1-k-3 m-1-k-3 commented May 18, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature, docs

  • What is the current behavior? (You can also link to an open issue here)

FACTextractor dependency is removed from EMBA
The message of an incompatible docker-compose version is improved - closing #247

  • What is the new behavior (if this is a feature change)? If possible add a screenshot.

No more FACTextractor anymore
Better message during installation if the docker-compose version is to old

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No more FACTextractor anymore included in deep-extraction mode

@m-1-k-3 m-1-k-3 added enhancement New feature or request Installation Installation issues labels May 18, 2022
@m-1-k-3 m-1-k-3 requested a review from p4cx May 18, 2022 11:18
@p4cx p4cx merged commit ba8d5f2 into e-m-b-a:master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p4cx p4cx p4cx approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Installation Installation issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-1-k-3 @p4cx