Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker-compose cleanup #891

Merged
merged 32 commits into from
Nov 21, 2023
Merged

Docker-compose cleanup #891

merged 32 commits into from
Nov 21, 2023

Conversation

m-1-k-3
Copy link
Member

@m-1-k-3 m-1-k-3 commented Nov 17, 2023 •
edited

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature

  • What is the current behavior? (You can also link to an open issue here)

Unblob installation manually
multiple unneeded docker-compose entries
nikto installation complicated with our read-only image
Kernel modules loaded from within the container
/root tmpfs in docker-compose cleaned

  • What is the new behavior (if this is a feature change)? If possible add a screenshot.

cleaned the above areas

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Needs new docker image.

  • Other information:

Do not merge it before uploading the new docker image

m-1-k-3 and others added 30 commits November 15, 2023 10:15
@m-1-k-3 m-1-k-3 added enhancement New feature or request docker docker related things EMBA labels Nov 17, 2023
@m-1-k-3 m-1-k-3 changed the title Cleanup agian Docker-compose cleanup Nov 17, 2023
@m-1-k-3 m-1-k-3 merged commit 293acd3 into e-m-b-a:master Nov 21, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenediktMKuehne BenediktMKuehne BenediktMKuehne approved these changes

Assignees
No one assigned
Labels
docker docker related things EMBA enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@m-1-k-3 @BenediktMKuehne