Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor variable usages #997

Merged
merged 19 commits into from
Jan 22, 2024
Merged

Refactor variable usages #997

merged 19 commits into from
Jan 22, 2024

Conversation

m-1-k-3
Copy link
Member

@m-1-k-3 m-1-k-3 commented Jan 18, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Fix 400 little bugs :-D

  • What is the current behavior? (You can also link to an open issue here)

multiple variable usages are not declared as external/local which results in automatically external declaration,

  • What is the new behavior (if this is a feature change)? If possible add a screenshot.

Start fixing

before: [-] Found 554 indirect global variables in all modules
current state: [-] Found 151 indirect global variables in all modules

The following modules are such a big mess that they will be handled in a dedicated PR:

  • ./modules/L10_system_emulation.sh - 96 violations
  • ./modules/F50_base_aggregator.sh - 55 violations

@m-1-k-3 m-1-k-3 added bug Something isn't working EMBA labels Jan 18, 2024
@m-1-k-3 m-1-k-3 marked this pull request as ready for review January 20, 2024 09:19
@m-1-k-3 m-1-k-3 requested review from HoxhaEndri and BenediktMKuehne and removed request for HoxhaEndri January 20, 2024 09:19
@m-1-k-3 m-1-k-3 merged commit d53fef3 into e-m-b-a:master Jan 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working EMBA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants