Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 👷 👽 ⬆️ Fix replaced mode display + upgrade dev dockerfile to use an image + bump up image #87

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

shankari
Copy link
Contributor

This is mainly to support the replaced mode fix; might as well check the others in as well.

We now have an e-mission-server image that includes miniconda and the basic
conda environment needed for e-mission. We have already changed the production
Dockerfile so that it is built off the image, and doesn't need to reinstall
conda and similar.

makes it similar to the production Dockerfile
e-mission@e45af89
…ed correctly

Bug reported by a user.
We should only use backticks for the text, not the value
Using backticks for the value as well results in

```
<img src="plots/`miles_e-bike_replaced_mode`_2023_06_default.png" alt="null" width="90%" height="90%">
```

instead of

```
<img src="plots/ntrips_e-bike_purpose_default.png" alt="Pie chart of Number of trips for each purpose for e-bike only
```

Simple one-line fix to make it like the purpose, which works

Testing done: None
This is pretty simple and I don't have an intern working on the public dashboard yet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant