Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 👷 👽 ⬆️ Fix replaced mode display + upgrade dev dockerfile to use an image + bump up image #87

Merged
merged 3 commits into from
Aug 15, 2023

Commits on Jul 13, 2023

  1. 👽 👷 Change the dev Dockerfile to also use an image for e-mission-server

    We now have an e-mission-server image that includes miniconda and the basic
    conda environment needed for e-mission. We have already changed the production
    Dockerfile so that it is built off the image, and doesn't need to reinstall
    conda and similar.
    
    makes it similar to the production Dockerfile
    e-mission@e45af89
    shankari committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    7f89972 View commit details
    Browse the repository at this point in the history
  2. ⬆️ Upgrade server image

    shankari committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    d0bc269 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. 🐛 Fix the backticks so that the replaced mode distribution is display…

    …ed correctly
    
    Bug reported by a user.
    We should only use backticks for the text, not the value
    Using backticks for the value as well results in
    
    ```
    <img src="plots/`miles_e-bike_replaced_mode`_2023_06_default.png" alt="null" width="90%" height="90%">
    ```
    
    instead of
    
    ```
    <img src="plots/ntrips_e-bike_purpose_default.png" alt="Pie chart of Number of trips for each purpose for e-bike only
    ```
    
    Simple one-line fix to make it like the purpose, which works
    
    Testing done: None
    This is pretty simple and I don't have an intern working on the public dashboard yet
    shankari committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    e5b5fbb View commit details
    Browse the repository at this point in the history