Fix news category breadcrumbs

[RichardBarrell]

The breadcrumbs for news categories were previously pointing to the category page but using the id of the news story instead of the id of the category.

Motivation and Context

The category breadcrumbs on /news.php?extend.${NEWS_ID} were pointing at /news.php?list.${NEWS_ID}.0 instead of /news.php?list.${NEWS_CATEGORY_ID}.0

Description

Pass an array to the e107::getUrl()->create invocation with the category's id instead of the story's id.

How Has This Been Tested?

• Deployed on our website at https://kyrgaming.com
• See news story at https://kyrgaming.com/news.php?extend.2
• The category breadcrumb was previously pointing to https://kyrgaming.com/news.php?list.2.0 erroneously, which showed "There are no news items for the specified category - please check back soon."
• With this fix, the category breadcrumb now points to https://kyrgaming.com/news.php?list.1.0 instead, which shows the correct news items in that category.
• (Tested on Ubuntu 18.04, php 7.2, mysql 5.7.)

Types of Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation (a change to man pages or other documentation)

Checklist

• My code adheres to the e107 code style standard.
• I have read the contributing document.
• I have added tests to cover my changes.
• All new and existing tests pass.

Existing unit tests on master are already failing for me, so I'm not touching that.

Deltik helped me get the unit tests running, thank you!

[CaMer0n]

@RichardBarrell Thank you!

[Jimmi08]

@CaMer0n @Deltik

Category_sef value is not needed anymore? This PR limited data to ID field, name value is missing.

[Deltik]

Mm, you're right to question this change, @Jimmi08. The core_news_sef_full_url eUrlConfig is broken now that news_sef is lost. We ought to restore the old behavior, write a regression test, then make the breadcrumbs work for all the supported SEF formats.

[RichardBarrell]

@Jimmi08 oh nooo! Sorry about that.

[Jimmi08]

@Deltik I think that problem was in that array content, not in code for URL. After sync - when I noticed this on gitter - I had to run core update, then old code (before this change) worked. - I couldn't add new category in admin area, there was still SQL error. After rerunning core update, everything worked. I just hadn't time to write more at that time. And this is used on many places so it would need to be changed there too...

@RichardBarrell no problem. I use this version only for testing, not on live sites. Without you I wouldn't know that I can run those tests locally. Something new for me :) Just my English is limited.

[Deltik]

I found ba18155 by @CaMer0n, which replaced category_id with id, but category_id was correct and id was not.

At this point:

url.php:138, core_news_url->create()
application.php:2097, eRouter->configCallback()
application.php:2250, eRouter->assemble()
e107Url.php:56, eUrl->create()
news.php:110, news_front->setBreadcrumb()
news.php:79, news_front->__construct()
news.php:2025, require_once()
news.php:23, {main}()

The value I have for $params is:

array (
  'news_id' => '5',
  'news_title' => 'Papilion Minter Savior',
  'news_sef' => 'papilion-minter-savior',
  'news_body' => '[html]<p>Ut wisi enim ad minim veniam, quis nostrud exerci tation ullamcorper suscipit lobortis nisl ut aliquip ex ea commodo consequat. Duis autem vel eum iriure dolor in hendrerit in vulputate velit esse molestie consequat, vel illum dolore eu feugiat nulla facilisis at vero eros et accumsan et iusto odio dignissim qui blandit praesent luptatum zzril delenit augue duis. Ut wisi enim ad minim veniam, quis nostrud exerci tation ullamcorper suscipit lobortis nisl ut aliquip ex ea commodo consequat.</p>[/html]',
  'news_extended' => '[html]<p>Ut wisi enim ad minim veniam, quis nostrud exerci tation ullamcorper suscipit lobortis nisl ut aliquip ex ea commodo consequat. Duis autem vel eum iriure dolor in hendrerit in vulputate velit esse molestie consequat, vel illum dolore eu feugiat nulla facilisis at vero eros et accumsan et iusto odio dignissim qui blandit praesent luptatum zzril delenit augue duis. Ut wisi enim ad minim veniam, quis nostrud exerci tation ullamcorper suscipit lobortis nisl ut aliquip ex ea commodo consequat. Duis autem vel eum iriure dolor in hendrerit in vulputate velit esse molestie consequat, vel illum dolore eu feugiat nulla facilisis at vero eros et accumsan et iusto odio dignissim qui blandit praesent luptatum zzril delenit augue duis Ut wisi enim ad minim veniam, quis nostrud exerci tation ullamcorper suscipit lobortis nisl ut aliquip ex ea commodo consequat. Duis autem vel eum iriure dolor in hendrerit in vulputate velit esse molestie consequat, vel illum dolore eu feugiat nulla facilisis at vero eros et accumsan et iusto odio dignissim qui blandit praesent luptatum zzril delenit augue duis</p>[/html]',
  'news_meta_title' => '',
  'news_meta_keywords' => 'fashion,food,slider',
  'news_meta_description' => 'Ut wisi enim ad minim veniam, quis nostrud exerci tation ullamcorper suscipit lobortis nisl ut aliquip ex ea commodo consequat. Duis autem vel eum iriure dolor in hendrerit in vulputate velit esse molestie consequat, vel illum dolore eu feugiat nulla facilisis at vero eros et accumsan et iusto odio dignissim qui blandit praesent luptatum zzril delenit augue duis. Ut wisi enim ad minim...',
  'news_meta_robots' => '',
  'news_datestamp' => '1464637347',
  'news_modified' => '0',
  'news_author' => '1',
  'news_category' => '3',
  'news_allow_comments' => '0',
  'news_start' => '0',
  'news_end' => '0',
  'news_class' => '0',
  'news_render_type' => '0',
  'news_comment_total' => '0',
  'news_summary' => '',
  'news_thumbnail' => '{e_THEME}voux/install/2_.jpg,{e_THEME}voux/install/8.jpg',
  'news_sticky' => '0',
  'news_template' => NULL,
  'user_id' => '1',
  'user_name' => 'admin',
  'user_customtitle' => '',
  'user_image' => '',
  'user_login' => '',
  'category_id' => '3',
  'category_name' => 'Fashion',
  'category_sef' => 'Fashion',
  'category_icon' => '',
  'category_meta_keywords' => 'fashion',
  'category_meta_description' => '',
  'id' => '5',
  'page' => NULL,
)

id is 5 because that's the news_id, but it ought to be 3 for the category_id. Now we have to figure out what the intention was with e107_plugins/news/news_categories_menu.php as the comment in the commit mentioned.

[Deltik]

Got a fix ready for review: #4984