Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation pressure_control missing #414

Closed
jkisse opened this issue Oct 17, 2022 · 2 comments · Fixed by #451
Closed

Documentation pressure_control missing #414

jkisse opened this issue Oct 17, 2022 · 2 comments · Fixed by #451
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@jkisse
Copy link
Collaborator

jkisse commented Oct 17, 2022

The documentation (read the docs) for the recently added pressure controllers is missing.
@jkisse jkisse added documentation Improvements or additions to documentation good first issue Good for newcomers labels Oct 17, 2022
@jkisse
Copy link
Collaborator Author

jkisse commented Oct 26, 2022

I think the docstring is also incorrect - it does not neccessarily have a constant mass flow, does it? @dlohmeier

@dlohmeier
Copy link
Collaborator

Hmm, that seems to be a mistake indeed.

@dlohmeier dlohmeier mentioned this issue Nov 4, 2022
Open
12 tasks
@jkisse jkisse mentioned this issue Jan 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add missing docu for pressure controller jkisse/pandapipes
2 participants
@dlohmeier @jkisse