Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix varsizeBlkAllocator panic when initilized with small size. #384

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

xiaoxichen
Copy link
Collaborator

When the allocator size is small, it is possible we have a size 0 level in slab, which will crash in constructing SlabCacheQueue

hkadayam
hkadayam previously approved these changes May 10, 2024
Copy link
Contributor

@hkadayam hkadayam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

When the allocator size is small, it is possible we have a size 0
level in slab, which will crash in constructing SlabCacheQueue

Signed-off-by: Xiaoxi Chen <xiaoxchen@ebay.com>
raakella1
raakella1 previously approved these changes Aug 14, 2024
Copy link
Contributor

@raakella1 raakella1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

Copy link
Contributor

@raakella1 raakella1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@raakella1 raakella1 merged commit 72a355e into eBay:master Aug 14, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VarsizeBlkAllocator crash when running with smaller chunk size.
3 participants