-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all callbacks #210
Comments
darkwebdev
added a commit
that referenced
this issue
Jun 28, 2023
darkwebdev
added a commit
that referenced
this issue
Jun 28, 2023
darkwebdev
added a commit
that referenced
this issue
Jun 28, 2023
darkwebdev
added a commit
that referenced
this issue
Jun 28, 2023
darkwebdev
added a commit
that referenced
this issue
Jun 28, 2023
darkwebdev
added a commit
that referenced
this issue
Jun 29, 2023
darkwebdev
added a commit
that referenced
this issue
Jun 29, 2023
darkwebdev
added a commit
that referenced
this issue
Jun 29, 2023
darkwebdev
added a commit
that referenced
this issue
Jun 30, 2023
darkwebdev
added a commit
that referenced
this issue
Jun 30, 2023
darkwebdev
added a commit
that referenced
this issue
Jun 30, 2023
darkwebdev
added a commit
that referenced
this issue
Jul 3, 2023
darkwebdev
added a commit
that referenced
this issue
Jul 3, 2023
darkwebdev
added a commit
that referenced
this issue
Jul 4, 2023
darkwebdev
added a commit
that referenced
this issue
Jul 4, 2023
darkwebdev
added a commit
that referenced
this issue
Aug 7, 2023
darkwebdev
added a commit
that referenced
this issue
Sep 8, 2023
* EbayMenu: Improve callbacks (#181) * Fix tests after merge * Remove global index.ts(js) * Fix EbayMenuItemProps type * Update all test/storybook imports * [#200] Update all test/storybook imports, fix lint errors * [FEAT] EbayMenuButton: new component (#156) Co-authored-by: Andrew Cho <ancho@ebay.com> * update snapshot * EbayMenuButton: fix how labels are rendered with icons * EbayMenu: fix types, add story checks * EbayMenuButton: update callbacks to reflect original ebayui API. * EbaySplitButton (#168) Co-authored-by: Andrew Cho <ancho@ebay.com> * add tests, WIP * [#210] update ebay-checkbox callbacks * [#210] fix types * [#210] Update fake-menu callbacks * [#210] Update icon-button callbacks * [#210] Update listbox-button callbacks * [#210] Update select callbacks * [#210] Update star-rating-select callbacks * [#210] Update tabs callbacks, remove href prop * [#210] Update video callbacks, fix report button * [#210] Update dialog callbacks * [#210] Update page-notice-section callbacks * [#210] Update pagination callbacks * [#210] Update radio callbacks, fix lint warnings * [#210] Update switch callbacks * [#210] Update textbox callbacks * [#210] Update section-notice callbacks, fix bugs * [#210] Update fake-menu-button callbacks * [#210] Update snapshots * fix storybook sample * Fixes due to PR feedback * Update video player onReport callback. * Add `baseEl` back to menu * Fix PR comments * Add baseEl on menu-button --------- Co-authored-by: Andrew Cho <ancho@ebay.com> Co-authored-by: hlimas <hlimas@ebay.com>
released in v5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to #171 we should add callbacks with correct arguments where Marko version does it.
Components to update/check:
issue in ebayUI markofixed)issue in ebayui markofixed)The text was updated successfully, but these errors were encountered: