Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all callbacks #210

Closed
22 tasks done
darkwebdev opened this issue Feb 2, 2023 · 1 comment
Closed
22 tasks done

Update all callbacks #210

darkwebdev opened this issue Feb 2, 2023 · 1 comment
Assignees
@darkwebdev
Labels
tech debt The update/fix/change is overdue
Milestone
v5

Comments

@darkwebdev
Copy link
Collaborator

darkwebdev commented Feb 2, 2023 •
edited

According to #171 we should add callbacks with correct arguments where Marko version does it.
Components to update/check:
darkwebdev added a commit that referenced this issue Jun 28, 2023
@darkwebdev
[#210] update ebay-checkbox callbacks
252a957
darkwebdev added a commit that referenced this issue Jun 28, 2023
@darkwebdev
[#210] fix types
5326e95
darkwebdev added a commit that referenced this issue Jun 28, 2023
@darkwebdev
[#210] Update fake-menu callbacks
41ea9e8
darkwebdev added a commit that referenced this issue Jun 28, 2023
@darkwebdev
[#210] Update icon-button callbacks
360b779
darkwebdev added a commit that referenced this issue Jun 28, 2023
@darkwebdev
[#210] Update listbox-button callbacks
053e1d4
darkwebdev added a commit that referenced this issue Jun 28, 2023
@darkwebdev
[#210] Update select callbacks
7b84e6c
darkwebdev added a commit that referenced this issue Jun 29, 2023
@darkwebdev
[#210] Update star-rating-select callbacks
532b370
darkwebdev added a commit that referenced this issue Jun 29, 2023
@darkwebdev
[#210] Update tabs callbacks, remove href prop
d4924bc
darkwebdev added a commit that referenced this issue Jun 29, 2023
@darkwebdev
[#210] Update video callbacks, fix report button
74dd041
@darkwebdev darkwebdev added the tech debt The update/fix/change is overdue label Jun 29, 2023
@darkwebdev darkwebdev added this to the v5 milestone Jun 29, 2023
@darkwebdev darkwebdev mentioned this issue Jun 29, 2023
Closed
darkwebdev added a commit that referenced this issue Jun 30, 2023
@darkwebdev
[#210] Update dialog callbacks
5218864
darkwebdev added a commit that referenced this issue Jun 30, 2023
@darkwebdev
[#210] Update page-notice-section callbacks
080e0b9
darkwebdev added a commit that referenced this issue Jun 30, 2023
@darkwebdev
[#210] Update pagination callbacks
b7016e1
darkwebdev added a commit that referenced this issue Jul 3, 2023
@darkwebdev
[#210] Update radio callbacks, fix lint warnings
1abf3c6
darkwebdev added a commit that referenced this issue Jul 3, 2023
@darkwebdev
[#210] Update switch callbacks
3e1862f
darkwebdev added a commit that referenced this issue Jul 4, 2023
@darkwebdev
[#210] Update textbox callbacks
2227bd1
darkwebdev added a commit that referenced this issue Jul 4, 2023
@darkwebdev
[#210] Update section-notice callbacks, fix bugs
3f2fdc7
darkwebdev added a commit that referenced this issue Aug 7, 2023
@darkwebdev
[#210] Update fake-menu-button callbacks
da8346b
darkwebdev added a commit that referenced this issue Aug 7, 2023
@darkwebdev
[#210] Update snapshots
b0d72b5
@darkwebdev darkwebdev self-assigned this Aug 9, 2023
darkwebdev added a commit that referenced this issue Sep 8, 2023
@darkwebdev @anch-0
[BREAKING] v5 (#220)
54b98ae 
* EbayMenu: Improve callbacks (#181)

* Fix tests after merge

* Remove global index.ts(js)

* Fix EbayMenuItemProps type

* Update all test/storybook imports

* [#200] Update all test/storybook imports, fix lint errors

* [FEAT] EbayMenuButton: new component (#156)

Co-authored-by: Andrew Cho <ancho@ebay.com>

* update snapshot

* EbayMenuButton: fix how labels are rendered with icons

* EbayMenu: fix types, add story checks

* EbayMenuButton: update callbacks to reflect original ebayui API.

* EbaySplitButton (#168)

Co-authored-by: Andrew Cho <ancho@ebay.com>

* add tests, WIP

* [#210] update ebay-checkbox callbacks

* [#210] fix types

* [#210] Update fake-menu callbacks

* [#210] Update icon-button callbacks

* [#210] Update listbox-button callbacks

* [#210] Update select callbacks

* [#210] Update star-rating-select callbacks

* [#210] Update tabs callbacks, remove href prop

* [#210] Update video callbacks, fix report button

* [#210] Update dialog callbacks

* [#210] Update page-notice-section callbacks

* [#210] Update pagination callbacks

* [#210] Update radio callbacks, fix lint warnings

* [#210] Update switch callbacks

* [#210] Update textbox callbacks

* [#210] Update section-notice callbacks, fix bugs

* [#210] Update fake-menu-button callbacks

* [#210] Update snapshots

* fix storybook sample

* Fixes due to PR feedback

* Update video player onReport callback.

* Add `baseEl` back to menu

* Fix PR comments

* Add baseEl on menu-button

---------

Co-authored-by: Andrew Cho <ancho@ebay.com>
Co-authored-by: hlimas <hlimas@ebay.com>
@darkwebdev
Copy link
Collaborator Author

released in v5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkwebdev darkwebdev

Labels
tech debt The update/fix/change is overdue
Projects
None yet
Milestone
v5
Development

No branches or pull requests
1 participant
@darkwebdev