-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Add browser policy and eslint plugin #74
Conversation
"ios_saf >= 7", | ||
"ie_mob >= 10", | ||
"Android >= 3" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually this should come from a global require, correct? We store it in the @eBay org? https://github.com/browserslist/browserslist#shareable-configs
/cc @senthilp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is the plan. For now, this should be ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created a task to track and prioritize it: #76.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super dooper!
Description
browserslist
definitioneslint-plugin-compat
Context
This helps define our browser support both internally and externally. The eBay policy has 3 tiers, so effectively we need to support tier 1 and 2 (as a component library). We could delineate the exact tiers and browsers, but I don't really want to repeat either the actual eBay Browser Policy or our
browserslist
.References
https://github.com/amilajack/eslint-plugin-compat
#53
#54
Screenshots
Failure looks like this: