Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Add browser policy and eslint plugin #74

Merged
merged 1 commit into from
Apr 3, 2018
Merged

Conversation

yomed
Copy link
Contributor

@yomed yomed commented Apr 2, 2018

Description

  • condense browser policy into a browserslist definition
  • use this list to drive eslint-plugin-compat

Context

This helps define our browser support both internally and externally. The eBay policy has 3 tiers, so effectively we need to support tier 1 and 2 (as a component library). We could delineate the exact tiers and browsers, but I don't really want to repeat either the actual eBay Browser Policy or our browserslist.

References

https://github.com/amilajack/eslint-plugin-compat
#53
#54

Screenshots

Failure looks like this:

  174:5  error  fetch is not supported in Safari 6, iOS Safari 7.0-7.1, IE Mobile 10, IE 9, Edge 12, Android Browser 3  compat/compat

✖ 1 problem (1 error, 0 warnings)

error An unexpected error occurred: "Command failed.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 236

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.96%

Totals Coverage Status
Change from base Build 216: 0.0%
Covered Lines: 406
Relevant Lines: 448

💛 - Coveralls

"ios_saf >= 7",
"ie_mob >= 10",
"Android >= 3"
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually this should come from a global require, correct? We store it in the @eBay org? https://github.com/browserslist/browserslist#shareable-configs

/cc @senthilp

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is the plan. For now, this should be ok.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created a task to track and prioritize it: #76.

Copy link
Contributor

@ianmcburnie ianmcburnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super dooper!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants