Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.7.0 PR prior to merge #744

Merged
merged 25 commits into from Jul 9, 2019
Merged

2.7.0 PR prior to merge #744

merged 25 commits into from Jul 9, 2019

Conversation

seangates
Copy link
Contributor

Description

Sanity check PR prior to merge to master.

@seangates seangates added the squash: NO thanks For pull requests only label Jul 8, 2019
@seangates seangates self-assigned this Jul 8, 2019
ianmcburnie
ianmcburnie previously approved these changes Jul 8, 2019
@ianmcburnie
Copy link
Contributor

Skin needs updating to 7.4.0 (once it's released on the skin side)

@seangates
Copy link
Contributor Author

@ianmcburnie Version updated.

@coveralls
Copy link
Collaborator

coveralls commented Jul 8, 2019

Pull Request Test Coverage Report for Build 2464

  • 51 of 54 (94.44%) changed or added relevant lines in 14 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+1.1%) to 90.188%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/ebay-combobox-readonly/index.js 6 7 85.71%
src/components/ebay-select/index.js 9 11 81.82%
Files with Coverage Reduction New Missed Lines %
src/components/ebay-carousel/index.js 1 94.62%
src/common/transition/index.js 2 52.46%
src/components/ebay-pagination/index.js 4 96.52%
Totals Coverage Status
Change from base Build 2456: 1.1%
Covered Lines: 1159
Relevant Lines: 1246

💛 - Coveralls

ianmcburnie
ianmcburnie previously approved these changes Jul 9, 2019
agliga
agliga previously approved these changes Jul 9, 2019
@seangates seangates dismissed stale reviews from agliga and ianmcburnie via 052db52 July 9, 2019 16:47
@seangates seangates merged commit fe74963 into master Jul 9, 2019
@ianmcburnie ianmcburnie deleted the 2.7.0 branch November 4, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squash: NO thanks For pull requests only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants