Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added old dot syntax to progress-stepper #1863

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Sep 9, 2022

Fixes #1862

  • This PR contains CSS changes
  • This PR does not contain CSS changes

NOTE
This PR also includes a fix to storybook. There is an issue where there was an argument passed to a mixin in listbox/combobox which was breaking on storybook start

Description

  • As some teams saw the new progress stepper changes, they needed a larger change to support the new syntax. This PR adds the old syntax as an option. We can pass progress-stepper__items--current to show the old syntax. This would also be updated in ebayui to add a new defaultState as current which would show the current item as a bubble and remove the line.
  • Added the old current icon
  • I only added storybook examples. I did not show this on docs because we don't want to support this more than a couple of versions

Notes

  • There was some issue with descending specificity which would require a complete restructure of the less file. Since this is temporary, I disabled it for one rule.

Screenshots

Screen Shot 2022-09-09 at 11 17 15 AM

Screen Shot 2022-09-09 at 11 17 31 AM

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@agliga agliga self-assigned this Sep 9, 2022
@agliga agliga marked this pull request as ready for review September 9, 2022 18:22
Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but not sure why we'd want to support old syntax since this is a major version release and major code changes/upgrades are to be expected.

@agliga
Copy link
Contributor Author

agliga commented Sep 9, 2022

The changes look good, but not sure why we'd want to support old syntax since this is a major version release and major code changes/upgrades are to be expected.

There was a large thread about this. Well sync up Monday

@agliga agliga merged commit 6518c20 into 15.0.0 Sep 12, 2022
@agliga agliga deleted the progress-stepper-backwards-compat branch September 12, 2022 16:47
agliga added a commit that referenced this pull request Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants