Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15.4.0 Release #1979

Merged
merged 6 commits into from
Jan 26, 2023
Merged

15.4.0 Release #1979

merged 6 commits into from
Jan 26, 2023

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Jan 25, 2023

Release pull request for 15.4.0 release.

agliga
agliga previously approved these changes Jan 26, 2023
@ianmcburnie
Copy link
Contributor

ianmcburnie commented Jan 26, 2023

My only issue is that we are introducing a new block level class called listbox-button--form when we already have something called btn--form that is used inside of listbox-button. Anyone looking at the code/docs is going to wonder why this is. So we should make their purpose more clear in the docs.

@agliga
Copy link
Contributor

agliga commented Jan 26, 2023

My only issue is that we are introducing a new block level class called listbox-button--form when we already have something called btn--form that is used inside of listbox-button. Anyone looking at the code/docs is going to wonder why this is. So we should make their purpose more clear in the docs.

Yes. But to add if we keep it as is and want to change the docs, lets first put out the release and then we can update docs after it goes out.

@ianmcburnie
Copy link
Contributor

ianmcburnie commented Jan 26, 2023

It needs deeper exploration around why we are keeping the white background listbox-button in the first place. Listbox-button is supposed to match look and feel of other form controls by default - at least that was the expectation last time I worked on this.

@ArtBlue ArtBlue merged commit 2b21448 into master Jan 26, 2023
@agliga agliga deleted the 15.4.0 branch February 27, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants