Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to rawWrite for output. #314

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

jondegenhardt
Copy link
Contributor

@jondegenhardt jondegenhardt commented Oct 1, 2020

Switch BufferedOutputRange to use File.rawWrite rather than File.write when writing to file. This has two effects:

  • Small performance gain on, up to 10% on some tools, but generally quite small.
  • On Windows, writes in binary mode rather than text mode. This means Unix newlines are written rather than Windows newlines.

Regarding Windows newlines - Window is not currently supported, but it is worthwhile moving Windows support forward. A newline policy on Windows is TBD, but writing Unix newlines is an improvement, as it would enable the tools to work with each other in pipelines, and it gets closer to having a working Windows test suite. Updates to Windows newline handling can occur after that. See Issue #310.

@codecov-commenter
Copy link

Codecov Report

Merging #314 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files          18       18           
  Lines        6970     6970           
=======================================
  Hits         6926     6926           
  Misses         44       44           
Impacted Files Coverage Δ
common/src/tsv_utils/common/utils.d 100.00% <100.00%> (ø)

@jondegenhardt jondegenhardt merged commit a6df24a into eBay:master Oct 1, 2020
@jondegenhardt jondegenhardt mentioned this pull request Oct 11, 2020
10 tasks
@jondegenhardt jondegenhardt deleted the buffered-output-raw-write branch February 27, 2021 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants