Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csv2tsv refactor #318

Merged
merged 3 commits into from
Oct 4, 2020
Merged

Conversation

jondegenhardt
Copy link
Contributor

@jondegenhardt jondegenhardt commented Oct 4, 2020

Some code refactoring:

  • Moved isBufferableInputSource and inputSourceByChunk to common/utils.d. They were also modified to take arbitrary ubyte input ranges, not just arrays.
  • Refactoring of end-of-record / end-of-line code in csv2tsv state machine.

@codecov-commenter
Copy link

Codecov Report

Merging #318 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #318   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files          18       18           
  Lines        7064     7068    +4     
=======================================
+ Hits         7018     7022    +4     
  Misses         46       46           
Impacted Files Coverage Δ
common/src/tsv_utils/common/utils.d 100.00% <100.00%> (ø)
csv2tsv/src/tsv_utils/csv2tsv.d 100.00% <100.00%> (ø)

@jondegenhardt jondegenhardt merged commit 8ed24a4 into eBay:master Oct 4, 2020
@jondegenhardt jondegenhardt deleted the csv2tv-refactor-03oct2020 branch October 4, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants