Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade python requirements and remove all warnings [20851] #747

Merged
merged 8 commits into from
May 9, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Apr 18, 2024

Description

Upgrade python requirements and remove all warnings.

Depends on:

Also add support for CMAKE_COMPILE_WARNING_AS_ERROR.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@richiware richiware changed the base branch from master to 3.0.x-devel April 18, 2024 05:49
@richiware richiware force-pushed the bugfix/remove-warning-in-docs branch 2 times, most recently from 25be55c to 06c0026 Compare April 18, 2024 05:51
@richiware richiware changed the title Upgrade python requirements and remove all warnings Upgrade python requirements and remove all warnings [20851] Apr 18, 2024
@richiware richiware force-pushed the bugfix/remove-warning-in-docs branch 2 times, most recently from 5a38fad to 5d6eed6 Compare April 19, 2024 10:27
@richiware richiware force-pushed the bugfix/remove-warning-in-docs branch from a5e1368 to b93cd9b Compare April 25, 2024 05:43
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz EduPonz force-pushed the bugfix/remove-warning-in-docs branch from b93cd9b to e7e347d Compare May 9, 2024 06:10
@EduPonz
Copy link
Member

EduPonz commented May 9, 2024

@richiprosima please test_3 this

Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Copy link
Member

EduPonz commented May 9, 2024

Sadly, 3.0 Ci is not prepared to run this CI; it is looking for a similar branch in Fast DDS which does not exist anymore, and on that failure it is not falling back to 3.0.x-devel. I've run the CI locally without problems so I'll go ahead and merge this.

@EduPonz EduPonz merged commit d6eeda0 into 3.0.x-devel May 9, 2024
3 checks passed
@EduPonz EduPonz deleted the bugfix/remove-warning-in-docs branch May 9, 2024 08:09
EduPonz added a commit that referenced this pull request May 13, 2024
* Refs #20631. Update requirements and fix warnings

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #20631. Add support for CMAKE_COMPILE_WARNING_AS_ERROR

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #20631. Fix getting fastdds branch in readthedocs

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #20631. Move note by suggestion

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #20631. Fix idl

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #20631. Remove forgotten lines

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #20631. Fixes

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #20631: Avoid duplicated transport_id in XMLTester

Signed-off-by: eduponz <eduardoponz@eprosima.com>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Co-authored-by: eduponz <eduardoponz@eprosima.com>
EduPonz added a commit that referenced this pull request May 14, 2024
* Refs #20631. Update requirements and fix warnings

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #20631. Add support for CMAKE_COMPILE_WARNING_AS_ERROR

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #20631. Fix getting fastdds branch in readthedocs

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #20631. Move note by suggestion

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #20631. Fix idl

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #20631. Remove forgotten lines

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #20631. Fixes

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #20631: Avoid duplicated transport_id in XMLTester

Signed-off-by: eduponz <eduardoponz@eprosima.com>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Co-authored-by: eduponz <eduardoponz@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants