Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20733] Document how to annotate members as key in XML types (backport #746) #755

Merged
merged 1 commit into from
May 10, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Apr 30, 2024

Description

This PR documents how to annotate members as key in XML types (@key equivalent)

@Mergifyio backport 2.13.x 2.10.x 2.6.x

Related implementation PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

This is an automatic backport of pull request #746 done by [Mergify](https://mergify.com).

Signed-off-by: eduponz <eduardoponz@eprosima.com>
(cherry picked from commit f95e5c9)
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesusPoderoso
Copy link
Contributor

@richiprosima please test this

@JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso added implementation-pending Marks doc PRs which corresponding implementation is not yet available on Fast DDS ci-pending and removed implementation-pending Marks doc PRs which corresponding implementation is not yet available on Fast DDS labels May 8, 2024
@JesusPoderoso
Copy link
Contributor

@richiprosima please test this

@JesusPoderoso JesusPoderoso merged commit c27e5e6 into 2.13.x May 10, 2024
4 checks passed
@JesusPoderoso JesusPoderoso deleted the mergify/bp/2.13.x/pr-746 branch May 10, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants