Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21184] Adjust type in get_dynamic_type_builder_from_xml_by_name to return DynamicTypeBuilder #818

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Jun 19, 2024

Description

This PR adjust the type of the method get_dynamic_type_builder_from_xml_by_name() to get DynamicTypeBuilder instead of DynamicType after the refactor of the corresponding implementation PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@elianalf elianalf added this to the v3.0.0 milestone Jun 19, 2024
@elianalf elianalf changed the title [21184] Adjust type in get_dynamic_type_builder_from_xml_by_name to return DynamicTypeBuilder instead of DynamicType [21184] Adjust type in get_dynamic_type_builder_from_xml_by_name to return DynamicTypeBuilder Jun 19, 2024
@elianalf elianalf force-pushed the feature/refactor_get_dynamic_type_builder branch from 3555f92 to 5a29727 Compare July 2, 2024 13:07
…er_from_xml_by_name() after refactor

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf force-pushed the feature/refactor_get_dynamic_type_builder branch from 5a29727 to a4d21da Compare July 3, 2024 07:33
@EduPonz EduPonz self-requested a review July 3, 2024 13:07
@EduPonz EduPonz merged commit 758dba8 into master Jul 3, 2024
4 checks passed
@EduPonz EduPonz deleted the feature/refactor_get_dynamic_type_builder branch July 3, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants