Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increasing GUID prefix uniqueness [10124] #1637

Merged
merged 17 commits into from
Dec 15, 2020
Merged

Increasing GUID prefix uniqueness [10124] #1637

merged 17 commits into from
Dec 15, 2020

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Dec 11, 2020 •
edited
Loading

This should fix #1633 by using a random value on the 6-th and 7-th bytes of the GUID prefix.

@MiguelCompany
Refs 10123. Add SystemInfo helper singleton.
1d799dd 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10123. Using SystemInfo on System.cpp.
25e5307 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10123. Moving VendorId_t to its own header.
a884718 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10123. Add GuidUtils helper singleton.
144ff4d 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10123. Use GuidUtils on RTPSDomain.
4034bd6 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10123. Deprecating System.
b3aa14c 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10123. Add random value to PID part of prefix.
01f6f05 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany changed the title Increasing GUID prefix uniqueness Increasing GUID prefix uniqueness [10124] Dec 11, 2020
@MiguelCompany MiguelCompany mentioned this pull request Dec 11, 2020
Closed
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany
Refs 10123. Uncrustify.
80f24bc 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10124. Using random_device as RNG.
fa8ae83 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10124. Using numeric_limits.
07c3cc3 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10124. Singletons should have private constructors.
d87bdbc 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10124. Rename singletons instance getters.
3f6a287 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10124. Fixed doc typo.
b5342af 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Can't set status; build failed.

@MiguelCompany
Refs 10124. Added unit test for GuidUtils.
32b0ced 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany marked this pull request as ready for review December 14, 2020 11:42
@richiware
Copy link
Member

richiware commented Dec 14, 2020 •
edited by MiguelCompany
Loading

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany
Refs 10124. Uncrustify.
81e1ede 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany
Refs 10124. Fixed warnings on MessageReceiver mock.
c73c415 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10124. Uncrustify.
b1b62af 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelBarro
MiguelBarro approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@MiguelBarro MiguelBarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware
Copy link
Member

richiware commented Dec 15, 2020 •
edited by MiguelCompany
Loading

Build status:

  • Linux Build Status
    • I have seen these failures elsewhere
  • Linux aarch64Build Status
  • Mac Build Status
    • The warning is being addressed on another PR
  • Windows Build Status
    • Known failures

@fujitatomoya
Copy link
Contributor

confirmed this PR fixes #1633 with kubernetes, talker and listener containers in the same pod can communicate.

@stevewolter
Copy link

Also confirmed that this patch solves the Kubernetes same-pod issue I'm seeing. Great work with the comments, this looks very well engineered.

@MiguelCompany MiguelCompany merged commit 7ca16e7 into master Dec 15, 2020
@MiguelCompany MiguelCompany deleted the bugfix/1633/master branch December 15, 2020 11:17
@imontesino imontesino restored the bugfix/1633/master branch December 17, 2020 06:46
This was referenced Dec 17, 2020
Merged
Merged
@MiguelCompany MiguelCompany deleted the bugfix/1633/master branch February 9, 2021 08:29
@MiguelCompany MiguelCompany mentioned this pull request Mar 25, 2021
Closed
@MiguelCompany MiguelCompany mentioned this pull request May 24, 2022
Closed
8 tasks
@fujitatomoya fujitatomoya mentioned this pull request Dec 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirVassiliev VladimirVassiliev VladimirVassiliev left review comments

@MiguelBarro MiguelBarro MiguelBarro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fast-DDS fails to transmit messages between containers on same Kubernetes pod [10123]
6 participants
@MiguelCompany @richiware @fujitatomoya @stevewolter @MiguelBarro @VladimirVassiliev