Discovery simplified [4739] #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build status:
|
julionce
reviewed
Feb 22, 2019
|
Build status:
|
julionce
force-pushed
the
feature/discovery_simplified
branch
from
c9caa7a
to
57f8fc7
Compare
|
Build status:
|
julionce
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified the usage of discovery module removing the "chosen" feature.
Rationale:
The use of the attribute
chosendo not add a feature itself, it only gives to the user a concrete result for a concrete case. The same result can only be also obtained with few lines of code by the user, and with better management for his side. Furthermore, the "chosen" feature was forcing the use of reserve data for the ip into theuxrAgentAddressstructure instead of a reference to an existant ip string.Modified the function names.
Rationale:
There were two diferent function names: unicast and multicast. However, the behavior behind theses functions is not exactly what the name means. The unicast version can also receive several multicast ips, and the multicast version can only serach agent into the default multicast with the default port. For that, theses names have been changed.