-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
esmvaltool update breaks Marrmot forcing #322
Comments
This is where ewatercycle picks up the forcing file: ewatercycle/src/ewatercycle/forcing/_marrmot.py Lines 71 to 73 in f384c18
That index-based lookup seems a bit fragile indeed |
Since ESMValGroup/ESMValCore@49c65db, preproc files are also included in the output retreived from the esmvaltool python api, unless the setting |
It would be good to add a check that we indeed get a |
* fix for #322 marrmot forcing * Fix linter issues * add tests - not working yet * fix tests * fix linter issues * inline comment * Update expected test outputs after to esmvaltool update * Update CHANGELOG.md Co-authored-by: Peter Kalverla <peter.kalverla@gmx.com>
I think an update in esmvaltool, or some other update somewhere, has broken the marrmot forcing routine in eWaterCycle.
line 73 in https://github.com/eWaterCycle/ewatercycle/blob/main/src/ewatercycle/forcing/_marrmot.py assumes that the first element in recipe_output contains the final resulting .mat file, but it does not anymore: now it points to the preproc directory.
I think line 73 needs to point more explicitly to the .mat file, without relying on the order of recipe_output to remain the constant?
See attached screenshot of the output:
The text was updated successfully, but these errors were encountered: