Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] add missing dependency to copy-maven-plugin #4750

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

line-o
Copy link
Member

@line-o line-o commented Feb 14, 2023

Description:

The copy maven plugin
did not run without specifying additional dependencies

  • override commons-io version to the one used by existdb (2.4.0-> 2.11.0)
  • add dependency on org.codehaus.plexus 1.1 (also used by appassembler)

Reference:

fixes #4749

Type of tests:

none

@sonarcloud
Copy link

sonarcloud bot commented Feb 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@line-o line-o requested a review from a team February 14, 2023 14:51
@line-o
Copy link
Member Author

line-o commented Feb 14, 2023

The windows tests finished successfully. 🎉

@joewiz
Copy link
Member

joewiz commented Feb 14, 2023

I can confirm that this fixes the bug described in #4749 for me, which I, too, encountered this morning when pulling from HEAD.

@line-o Thank you!

@line-o line-o requested a review from a team February 14, 2023 17:54
@line-o
Copy link
Member Author

line-o commented Feb 14, 2023

I also opened an issue on the maven plugin Antibrumm/copy-maven-plugin#7

@dizzzz dizzzz merged commit 95c9f75 into eXist-db:develop Feb 15, 2023
@adamretter adamretter added this to the eXist-7.0.0 milestone Apr 9, 2023
@adamretter adamretter added the bug issue confirmed as bug label Apr 9, 2023
@line-o line-o deleted the fix/assembly branch July 21, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issue confirmed as bug needs 6.x.x backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cannot package from develop branch due to failure in copy goal
5 participants