Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup app.packageCollection after use #241

Closed
duncdrum opened this issue Jul 4, 2022 · 2 comments
Closed

cleanup app.packageCollection after use #241

duncdrum opened this issue Jul 4, 2022 · 2 comments

Comments

@duncdrum
Copy link
Contributor

duncdrum commented Jul 4, 2022

db/pkgtmp used for xar installs hangs around after use, which adds another location where outdated xars might unneccesarily accumulate.

since this is a temporary collection, node-exist should clean up after itself, without user intervention

@line-o
Copy link
Member

line-o commented Jul 20, 2022

I now recall why I did not cleanup after each installation but opted instead to export the temporary collection.
The idea was that on batch installations the creation and removal of the temporary collection would only have to be done once.
That would leave it to the script using this feature of node-exist can decide when and if to remove the XAR package.
Maybe it is useful to keep a XAR that failed to install inside the database for further inspection.

@line-o line-o changed the title cleanup /db/pktmp after use cleanup app.packageCollection after use Aug 8, 2022
@line-o
Copy link
Member

line-o commented Jan 10, 2023

I believe this should be done by packages using this library not the library itself.

@line-o line-o closed this as completed Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants