Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve lookup heuristic #26

Closed
eagleflo opened this issue Jun 28, 2023 · 1 comment
Closed

Improve lookup heuristic #26

eagleflo opened this issue Jun 28, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@eagleflo
Copy link
Owner

~ % jisho ある限り
~ % jisho "all (there is)"
ある限り【あるかぎり】- all (there is), as long as there is

That's not ideal. The original very naïve piece of code just looked at the first character of the input when deciding which HashMap to look from. I rewrote it so that if there is any 漢字 in the query we look at keb rather than reb. Likewise reading lookups now require the whole input to be in 仮名; according to JMdict DTD reb is restricted to 仮名.

@eagleflo eagleflo added the enhancement New feature or request label Jun 28, 2023
@eagleflo
Copy link
Owner Author

Fixed in 9c3fe27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant