Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TC blocks calculated in a wrong way? #2

Closed
leodmel opened this issue Jul 2, 2019 · 2 comments
Closed

TC blocks calculated in a wrong way? #2

leodmel opened this issue Jul 2, 2019 · 2 comments

Comments

@leodmel
Copy link

leodmel commented Jul 2, 2019

I guess the code in the file blocks.py

int(math.ceil(math.log(seq_length)))

is wrong? Because math.log(x) return the natural logarithm of x, and I suppose we want a base-2 logarithm of x here?

@eambutu
Copy link
Owner

eambutu commented Jul 2, 2019

Wow you're right, that's a pretty big bug. Pushing a fix out right now. Unfortunately, I don't have access to compute resources for the time being, so I'm unable to rerun the numbers though.

@leodmel
Copy link
Author

leodmel commented Jul 3, 2019

That's alright 👍

@leodmel leodmel closed this as completed Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants