Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on launch #1

Closed
naronald opened this issue Sep 27, 2021 · 3 comments
Closed

Crash on launch #1

naronald opened this issue Sep 27, 2021 · 3 comments

Comments

@naronald
Copy link
Collaborator

Hi,

I am unable to replicate this -- the API calls are working to the non-weather data as the Logs are printing out what is expected.

Was it any API that was failing or weather in particular?

@Eamo5
Copy link
Owner

Eamo5 commented Sep 28, 2021

Hi Nicole,

This is a really perplexing issue if it works for you. Both Volley and Retrofit aren't working for me with both the desired weather API and the current test API with my HEAD checked out at 178a6ea. I cannot see any response in logcat and have attempted the connection on 3 seperate internet connections and the content appears fine on a browser.

I've used my actual Pixel 4 XL for testing instead of the emulator and inspecting the logcat on my Android device over ADB, it appears the connection is working. I'm not exactly sure what the issue here may be but I guess for now I'll deploy on my phone rather than an emulator.

If you have any suggestions they'd be appreciated. Not even using my phone's hotspot for the laptop works so I'm really uncertain.

While I've got you here, is there any preference of using Volley over Retrofit or vice versa in terms of good practices?

Thank you for your help,
Eamon

@Eamo5
Copy link
Owner

Eamo5 commented Sep 28, 2021

Ah so after some further investigation, it turns out my emulator had no internet connection whatsoever. After following the steps at https://stackoverflow.com/a/57305704 my issue appears to be fixed and a connection can be established. Apologies and thanks for your help!

@Eamo5 Eamo5 closed this as completed Sep 28, 2021
@naronald
Copy link
Collaborator Author

That's always entertaining -- I should note I tested on an emulator rather than my device (both Pixel 4a).

I'd go with Retrofit -- there are notes on this coming up in module 10 that outline the differences a little more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants