Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppressShowKeyBindingsNotice gets saved even when it is not required #478

Closed
GandalfSaxe opened this issue Aug 15, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@GandalfSaxe
Copy link

commented Aug 15, 2018

I always get this added to user settings.json:

  "gitlens.advanced.messages": {
    "suppressShowKeyBindingsNotice": true
  }

Shouldn't this just be a default setting if it insists on adding itself just upon opening VSCode with GitLens enabled, without any user interaction?

@eamodio eamodio self-assigned this Aug 16, 2018

@eamodio eamodio added the type: bug label Aug 16, 2018

@eamodio eamodio added this to the Soon™ milestone Aug 16, 2018

@eamodio

This comment has been minimized.

Copy link
Owner

commented Aug 16, 2018

That is a message that only shows up if you are using the alt-based keymap ("gitlens.keymap": "alternate"). And there was a bug that suppresses the message even though you've never seen it.

@eamodio eamodio changed the title What is suppressShowKeyBindingsNotice and why is it adding itself? suppressShowKeyBindingsNotice gets saved even when it is not required Aug 16, 2018

@eamodio eamodio closed this in 754ffc4 Aug 18, 2018

@GandalfSaxe

This comment has been minimized.

Copy link
Author

commented Aug 20, 2018

Isn't the alt keymap the default?

I still don't understand why a bug is fixed with a force-fed user setting, cluttering up the user settings file for no apparent reason :)

@eamodio

This comment has been minimized.

Copy link
Owner

commented Aug 20, 2018

It is not the default (though it used to be -- it used to be the only until all the conflicts with different keyboard layouts and languages). You now only need that setting if you are using the alternate keymap, because without it, it will prompt you to ask if you'd like to switch to another keymap (this was added because I received LOTS of issues and needed to forcibly get everyone to use another keymap UNLESS they were happy with how alternate was working for them.

@GandalfSaxe

This comment has been minimized.

Copy link
Author

commented Aug 21, 2018

I see, I must've inadvertently activated alt alternate keymap then, I thought I used the default. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.