Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of pytest for testing and use GitHub Actions #17

Open
J535D165 opened this issue Sep 27, 2022 · 8 comments
Open

Make use of pytest for testing and use GitHub Actions #17

J535D165 opened this issue Sep 27, 2022 · 8 comments

Comments

@J535D165
Copy link
Contributor

I think the pytest framework can be useful to test the package. It's more flexible and readable.

Also, making use of GitHub Actions would be nice.

@earnestt1234
Copy link
Owner

Not very familiar with GitHub Actions, but seems nice 😄. Having automatic testing on push or deployment to PyPI on release would be very nice.

And I am okay with moving to pytest if that is recommended or better for GitHub Actions. I didn't have a strong reason for going with unittest. I'm a little tied up for the next couple weeks but could revisit after that.

@J535D165
Copy link
Contributor Author

J535D165 commented Oct 4, 2022

Nice, happy to review.

@earnestt1234
Copy link
Owner

earnestt1234 commented Oct 31, 2022

Didn't get around to addressing this for at all for the new version. Still planning to look into this, but will need to do some learning & testing

@J535D165
Copy link
Contributor Author

J535D165 commented Nov 1, 2022

No worries. Version 0.4 is a nice improvement.

I'm working on a project, J535D165/scitree, which relies heavily on seedir. I want to propose some changes to the seedir API as I think they are both valuable for scitree and seedir. But the tests are holding me back at the moment. But there is no hurry for me :) Will work on this later.

@earnestt1234
Copy link
Owner

That sounds great! Interested to hear your suggestions. Thanks for sharing your project, looks cool!

I generally want to improve/augment the testing suite for seedir. But still collecting my thoughts on what changes exactly. But I will port things to pytest as I am doing so

@earnestt1234
Copy link
Owner

😪 Only took 2 years but finally made the tests pytest compatible: aeb1d25. Should have just made ChatGPT do it.

@J535D165 not sure if you are still interested, but you can explore/propose your API changes now.

I still have not learned GitHub actions - still sounds appealing to me but haven't put the time in. I probably will not be able to pursue in the near feature, however, unless other changes necessitate it.

@J535D165
Copy link
Contributor Author

Great. Maybe I will look into it during my summer break in August.

@timweissenfels
Copy link
Contributor

Hahaha, I just got a push notification for this issue, so crazy to see you guys revisiting this package 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants