-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modis data clarification and CI fixes #497
Conversation
updating earthpy
Updating from EarthPy master
Updating from earthpy repo
Updating from master
Updating from master
Fixed the last two vignettes so that their thumbnails work. (earthlab#407)
Updating!
Updating from master
Updating from master
Updating!
updating from master
… that's contained. It's not actually h5 data.
@lwasser @jlpalomino and I talked about this dataset and the data contained within it and we realized that the name was in fact wrong! It was a quick little fix so I figured I'd make a PR to correct the error. Let me know if I need to do anything else to this PR! |
Failed with environmental issue bc pyproj still defines |
docs seems to be failing due to a dead link that's accessed in |
Codecov Report
@@ Coverage Diff @@
## master #497 +/- ##
=====================================
Coverage 95% 95%
=====================================
Files 25 25
Lines 1660 1660
=====================================
Hits 1577 1577
Misses 83 83
Continue to review full report at Codecov.
|
@lwasser CI is happy now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!! Thank you for this fix @nkorinek !! I'll bump version soonish so we can use this in class next week w the correct dirnames!
Modis data clarification and CI fixes (earthlab#497)
Changing the name of the MODIS HDF dataset to accurately represent the data inside of it, i.e., H4 data instead of H5 data.