Modis data clarification and CI fixes #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating earthpy
Updating from EarthPy master
Updating from earthpy repo
Updating from master
Updating from master
Fixed the last two vignettes so that their thumbnails work. (earthlab#407)
Updating!
Updating from master
Updating from master
Updating!
updating from master
… that's contained. It's not actually h5 data.
|
@lwasser @jlpalomino and I talked about this dataset and the data contained within it and we realized that the name was in fact wrong! It was a quick little fix so I figured I'd make a PR to correct the error. Let me know if I need to do anything else to this PR! |
|
Failed with environmental issue bc pyproj still defines |
|
docs seems to be failing due to a dead link that's accessed in |
Codecov Report
@@ Coverage Diff @@
## master #497 +/- ##
=====================================
Coverage 95% 95%
=====================================
Files 25 25
Lines 1660 1660
=====================================
Hits 1577 1577
Misses 83 83
Continue to review full report at Codecov.
|
nkorinek
changed the title
|
@lwasser CI is happy now! |
nkorinek
added a commit
to nkorinek/earthpy
that referenced
this pull request
Mar 10, 2020
Modis data clarification and CI fixes (earthlab#497)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the name of the MODIS HDF dataset to accurately represent the data inside of it, i.e., H4 data instead of H5 data.