fixed wrong link in docs #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwasser
commented
Aug 2, 2018
secrets/bootcamp-hub.yaml
Outdated
| auth: | ||
| type: github | ||
| github: | ||
| clientID: 49802dd585160dac9ab8 |
There was a problem hiding this comment.
it's not so secret. @betatim i believe i'm missing an important secret step.
betatim
reviewed
Aug 3, 2018
secrets/bootcamp-hub.yaml
Outdated
| @@ -0,0 +1,6 @@ | |||
| jupyterhub: | |||
There was a problem hiding this comment.
let's remove this file from this PR
added 3 commits
August 3, 2018 08:11
updating from master
betatim
reviewed
Aug 3, 2018
| @@ -82,7 +82,7 @@ Step two: Setup authentication | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
| Next decide how you'd like to authenticate your hub. You can use Github, | |||
| Google or a "hash" based authenticator. Read more about that here | |||
| `Read more about that here <https://earthlab-hub-ops.readthedocs.io/en/latest/>`_ | |||
| `Read more about that here <https://earthlab-hub-ops.readthedocs.io/en/latest/authentication.html>`_ | |||
There was a problem hiding this comment.
We should find a way to do this without having to have the explicit URL here, something to fix in a new PR though, let's not hold this one up.
There was a problem hiding this comment.
cool... open to any ideas on that!
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.