Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed wrong link in docs #87

Merged
merged 8 commits into from
Aug 3, 2018
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/source/day-to-day.rst
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ Step two: Setup authentication
~~~~~~~~~~~~
Next decide how you'd like to authenticate your hub. You can use Github,
Google or a "hash" based authenticator. Read more about that here
`Read more about that here <https://earthlab-hub-ops.readthedocs.io/en/latest/>`_
`Read more about that here <https://earthlab-hub-ops.readthedocs.io/en/latest/authentication.html>`_
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should find a way to do this without having to have the explicit URL here, something to fix in a new PR though, let's not hold this one up.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool... open to any ideas on that!


Step three: Update the travis build so it recognizes the new hub
~~~~~~~~~~~~
Expand Down
9 changes: 7 additions & 2 deletions docs/source/tooling.rst
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ the terminal, enter:

gcloud components install kubectl

IMPORTANT: you must close and reopen the terminal after installing gcloud
command line tool for it to recognize the gcloud command that you need to install
kubernetes locally.


.. _helm:

Expand All @@ -44,8 +48,9 @@ exist if you prefer to install without using the script.
Verify helm
~~~~~~~~~~~

You can verify that you have the correct version and that helm installed
properly by running:
Once you have installed help, close and reopen your terminal window for it to
be properly recognized. Then, you can verify that you have the correct version
and that helm installed properly by running:

.. code:: bash

Expand Down
6 changes: 6 additions & 0 deletions secrets/bootcamp-hub.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
jupyterhub:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove this file from this PR

auth:
type: github
github:
clientID:
clientSecret: