Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: Remove Percy #1033

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Dependencies: Remove Percy #1033

merged 1 commit into from
Oct 1, 2023

Conversation

amotl
Copy link
Member

@amotl amotl commented Sep 30, 2023

Percy should actually be pulled in appropriately by dash[testing], right? So, it should do no harm removing the direct dependency to percy-selenium here. CI may prove me wrong ;].

It should actually be pulled in appropriately by dash[testing], right?
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7162ddf) 89.69% compared to head (0c1de60) 89.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1033      +/-   ##
==========================================
+ Coverage   89.69%   89.70%   +0.01%     
==========================================
  Files         103      103              
  Lines        9497     9497              
  Branches     1056     1056              
==========================================
+ Hits         8518     8519       +1     
+ Misses        765      764       -1     
  Partials      214      214              
Flag Coverage Δ
unittests 89.70% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gutzbenj gutzbenj merged commit 80b0c1d into main Oct 1, 2023
17 checks passed
@gutzbenj gutzbenj deleted the amo/no-percy branch October 1, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants