Add CITATION.cff #841
Add CITATION.cff #841
Conversation
Codecov ReportBase: 89.53% // Head: 89.55% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #841 +/- ##
==========================================
+ Coverage 89.53% 89.55% +0.01%
==========================================
Files 101 101
Lines 7205 7206 +1
Branches 672 672
==========================================
+ Hits 6451 6453 +2
+ Misses 585 584 -1
Partials 169 169
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Thank you for this patch. I think it is sweet to generate the citation file from project metadata. However, I am not sure if that should be part of the |
|
I excluded the file via |
It will still count towards code coverage. Maybe let's add it into a |
wetterdienst/__citation__.py
Outdated
| content = Path(ROOT / "pyproject.toml").read_text() | ||
| raw = tomli.loads(content) | ||
| config = {"project": raw["tool"]["poetry"]} | ||
| config["project"]["authors"] = [{"name": author.split("<")[0][:-1]} for author in config["project"]["authors"]] |
There was a problem hiding this comment.
Is this the only modification to the upstream code? I am just trying to get a grip on the details, to eventually submit your improvements back to the cff-from-621 project.
There was a problem hiding this comment.
Those two adjustments had to be made because cff-from-621 does not support poetry type format.
wetterdienst/__citation__.py
Outdated
| """ | ||
| content = Path(ROOT / "pyproject.toml").read_text() | ||
| raw = tomli.loads(content) | ||
| config = {"project": raw["tool"]["poetry"]} |
There was a problem hiding this comment.
Oh. This line is probably also needed for compatibility with Poetry?
This adds
Notice: release date is not parsed from changelog (possible source) but just set to current date