add cuda.py #145
add cuda.py #145
Conversation
Signed-off-by: Fotis Georgatos <fotis.georgatos@uni.lu>
| cmd = install_script + " --prefix=" + self.installdir | ||
| else: | ||
| # the following would require to include "osdependencies = 'libglut'" because of -samples | ||
| # installparams = "-samplespath=%s/samples/ -toolkitpath=%s -samples -toolkit" % (self.installdir, self.installdir)) |
There was a problem hiding this comment.
@fgeorgatos: Please create an issue to fix this. We should actually (optionally) install the samples and use them as a kind of test suite for CUDA, to verify that it works (it should probably be enabled by default). We can dynamically require libglut as a dependency if the samples are being built/installed.
There was a problem hiding this comment.
I like the idea of the samples install being optional, and passed in via the CUDA-5.0.35.eb file. I think it should be enabled by default but that's not a strong opinion. Then the choice of whether to install the samples is just a change to the EasyConfig.
There was a problem hiding this comment.
I agree that installing the samples should be enabled by default. The libglut dependency should be easy to fulfill with EasyBuild.
There was a problem hiding this comment.
A dedicated issue was created to enhance the easyblock for the samples, see #147.
|
Except for the permissions issue, this looks fine to me. (not sure why this exists... was a problem observed during an install?) |
…around on issue on systems where an X11 term is being used
don't use full path for Perl install scripts, unset DISPLAY env var
…easyblocks into contrib_CUDA_easyblock
…ir, not needed (leftovers from easyblock that was used as a base for this one)
check unsetting of DISPLAY, remove chmod'ing that's obsolete
|
Looks good! |
add docstring, get rid of obsolete mkdir command
|
This has seen extensive testing together with easybuilders/easybuild-easyconfigs#164, and after a couple of rounds of improvements, should now be ready for production, so merging it in. CUDA support in toolchains in the framework is in the works. |
Signed-off-by: Fotis Georgatos fotis.georgatos@uni.lu