Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sanity check for libnpp for CUDA 5.5 compat #238

Merged
merged 1 commit into from
Aug 19, 2013

Conversation

ajdecon
Copy link
Contributor

@ajdecon ajdecon commented Aug 7, 2013

CUDA 5.5 splits libnpp into three libraries: libnppc, libnppi and
libnpps. This causes the sanity check for libnpp.so to fail on version
5.5.22.

Simply removed this check to maintain compatibility with CUDA 5.0. It's
debatable whether it's better to special-case this check by version, but
given that the CUDA installer is monolithic we probably don't need this
check in addition to the others.

Also removed executable bit from cuda.py permissions for consistency
with other EasyBlocks.

CUDA 5.5 splits libnpp into three libraries: libnppc, libnppi and
libnpps. This causes the sanity check for libnpp.so to fail on version
5.5.22.

Simply removed this check to maintain compatibility with CUDA 5.0. It's
debatable whether it's better to special-case this check by version, but
given that the CUDA installer is monolithic we probably don't need this
check in addition to the others.

Also removed executable bit from cuda.py permissions for consistency
with other EasyBlocks.
@fgeorgatos
Copy link
Collaborator

This is a good example of why the list of files to be sanity-checked,
should rather fall on the side of easyconfigs, rather than easyblock;

AFAIK, George shares the same view like me, but not the Ghent team;
can we guys elaborate on this to find the solution that makes us all thing it is optimal?

My stance is that, in the name of orthogonality, over time the list of files to check can expand arbitrarily, and that should not end up as spam on the easyblock (I view the easyblock as an engine fed with easyconfig fuel ;-)

@ajdecon
Copy link
Contributor Author

ajdecon commented Aug 15, 2013

This is a good example of why the list of files to be sanity-checked, should rather fall on the side of easyconfigs, rather than easyblock;

After thinking a bit, I agree. I think it would make sense to put anything which might be expected change from one release to the next in the easyconfig.

@boegel
Copy link
Member

boegel commented Aug 19, 2013

@ajdecon: I agree that simply removing npp is a viable option here, since the list is already non-exhaustive anyway. So, I'll merge this in, thanks for the PR!

We have consistently defined custom sanity check paths in easyblocks because it's the correct place, in our view. Anything that is required to make a build successful should be included in the easyblock, and the easyconfig file should be kept as simple as possible (note: we could make it even more minimal, by moving homepage, description, etc. to the easyblock as well). Usually, the version-specific differences in sanity check paths are fairly minor. This policy really helps with the maintainability of easyconfigs (especially in the absence of fat easyconfigs, i.e. one easyconfig per software package).
That being said: sanity check paths that are specified in easyconfig files always get preference over what is specified in the easyblocks, so the kind of support you want is actually already there...

boegel added a commit that referenced this pull request Aug 19, 2013
Remove sanity check for libnpp for CUDA 5.5 compat
@boegel boegel merged commit aabbfb2 into easybuilders:develop Aug 19, 2013
@ajdecon ajdecon deleted the cuda5.5 branch August 20, 2013 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants