Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update documentation on Singuluarity integration w.r.t. recent changes #514

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

@boegel boegel added the update label Jun 5, 2019
@boegel boegel added this to the next release (3.9.2) milestone Jun 5, 2019

* Python 2.6 or 2.7
* Lmod
* standard tools & utilities like ``make``, ``patch``, ``tar``, etc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this list complete? Does a standard centos image sufffice?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, some things will be missing (e.g. bzip2 is not there by default, it seems).

Making the list complete here will be a PITA to maintain, I'd rather maintain it only in the code.

In practice, people should start with a base image created via a recipe generated by EasyBuild, then all should be fine.

yum install --quiet --assumeyes patch make
yum install --quiet --assumeyes file git which
yum install --quiet --assumeyes python-pip
yum install --quiet --assumeyes gcc-c++
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are this all separate calls to yum? It will be quicker when combined.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's just because they're listed separately in the code, I doubt it'll make a huge difference when we do everything in one go though?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just timed it, total time (incl. pip install easybuild and eb bzip2-1.0.6.eb), I don't see much (if any) difference between running multiple yum install commands vs one big yum install.

In addition, the yum install epel-release has to be done separately, otherwise installing python-pip and Lmod fails.

I don't think it's worth making the generated recipe harder to read for humans for a matter of seconds at best?

@wpoely86 wpoely86 merged commit a565ef1 into easybuilders:develop Jun 6, 2019
@boegel boegel deleted the containers branch June 6, 2019 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants