Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev #264

Merged
merged 6 commits into from Dec 10, 2019
Merged

dev #264

merged 6 commits into from Dec 10, 2019

Conversation

DominiqueMakowski
Copy link
Member

No description provided.

@DominiqueMakowski
Copy link
Member Author

And on the side, a facetted plot of the evolution of indices of significance:

We could then think about having multiple "evidence accumulation plots" depending on parameters SUCH AS prior specification (we could be cool for papers, as supp material or what)

@strengejacke
Copy link
Member

?

@DominiqueMakowski
Copy link
Member Author

lol I am trying to create a fancy plot that we could use at least in the README and vignettes 😁

@DominiqueMakowski
Copy link
Member Author

DominiqueMakowski commented Dec 9, 2019

@mattansb
Copy link
Member

mattansb commented Dec 9, 2019

That is so cool!!!! We should use that in the priors paper!

@DominiqueMakowski
Copy link
Member Author

Thanks @mattansb for a more enthusiastic comment than a depressing "?" 😬

@strengejacke
Copy link
Member

😱
I just successfully reduced package size ~1mb, and now it's being filled with strange animations.

@DominiqueMakowski
Copy link
Member Author

okay okay I'll move it to easystats/easystats 😠 😄

@codecov-io
Copy link

codecov-io commented Dec 9, 2019

Codecov Report

Merging #264 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
+ Coverage   55.63%   55.66%   +0.02%     
==========================================
  Files          59       59              
  Lines        2545     2544       -1     
==========================================
  Hits         1416     1416              
+ Misses       1129     1128       -1
Impacted Files Coverage Δ
R/print.bayesfactor_parameters.R 0% <ø> (ø) ⬆️
R/print.bayesfactor_models.R 0% <0%> (ø) ⬆️
R/print.bayesfactor_restricted.R 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f4119f...27f9d16. Read the comment docs.

@DominiqueMakowski
Copy link
Member Author

PS: @mattansb in print.bf_parameters, I swapped the column name as "Bayes factor" in favour of BF so its consistent with the actual name of the column (just now I got confused by trying to pull a column named "Bayes factor") (and to avoid redundancy as "Bayes Factor" is in the header)

@mattansb
Copy link
Member

mattansb commented Dec 9, 2019

@DominiqueMakowski then I think you might need to also change it in the other print method...?

@DominiqueMakowski
Copy link
Member Author

which other?

DominiqueMakowski added a commit to easystats/easystats that referenced this pull request Dec 9, 2019
@mattansb
Copy link
Member

mattansb commented Dec 9, 2019

@DominiqueMakowski post this gif to twitter!! It's sooooo cooooollll!

@DominiqueMakowski
Copy link
Member Author

I am waiting for the final fixed version (it takes ages to compute 😅)

@DominiqueMakowski
Copy link
Member Author

Here it is with 60 participants :)

Can we merge this?

@mattansb
Copy link
Member

mattansb commented Dec 9, 2019

Merge to Twitter? ✔

@DominiqueMakowski
Copy link
Member Author

(merged to twitter 😁) Now the PR?

@strengejacke strengejacke merged commit d29a4f6 into master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants