Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-rename change_code()? #233

Closed
IndrajeetPatil opened this issue Aug 24, 2022 · 6 comments · Fixed by #235
Closed

Re-rename change_code()? #233

IndrajeetPatil opened this issue Aug 24, 2022 · 6 comments · Fixed by #235

Comments

@IndrajeetPatil
Copy link
Member

Before we finalize this, we should definitely decide on the new function names. Mostly, I'm not quite satisfied with change_code(). recode is a verb, and everyone would expect such a function would recode old into new values. in change_code(), the verb is change, and what can we expect if we change a code? What we actually change when recoding are values (or factor levels, but values is maybe more generic). What do you think about change_values()? or maybe recode_values(), or recode_variables().

Originally posted by @strengejacke in #87 (comment)

@IndrajeetPatil
Copy link
Member Author

The "code" being the mapping of quantities to values/labels. So the function is changing the coding scheme used.

Maybe change_coding()? change_values() would be my second choice

Originally posted by @bwiernik in #87 (comment)

@bwiernik
Copy link
Contributor

I like change_coding() or recode_values()

@DominiqueMakowski
Copy link
Member

recode_values() +1

@IndrajeetPatil
Copy link
Member Author

@strengejacke I don't think this is low priority.

We need to finish renaming in as few release cycles as possible. We can't keep changing function names every time we update the package; it doesn't reflect well on us.

I would like to be done with renaming for the existing functions in the next (0.6) release.

@strengejacke
Copy link
Member

ok, than let's go for recode_values().

@bwiernik
Copy link
Contributor

In the future, if there are lingering concerns about renaming a function or argument, I'd like to not merge or at least not release until there is consensus. Eg, we probably should have left data_recode() in place until we settled on an alternative everyone was happy with

IndrajeetPatil added a commit that referenced this issue Aug 25, 2022
Closes #233

Co-authored-by: Daniel <mail@danielluedecke.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants