-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some aliases #504
Remove some aliases #504
Conversation
Test failures same as #502 (comment) |
Looks like we have some encoding issues for Windows prior to == Failed tests ================================================================
-- Failure ('test-data_read.R:348:5'): data_read, convert many labels correctly --
attributes(d$selv1)$labels (`actual`) not identical to c(...) (`expected`).
names(actual) vs names(expected)
- "Vignette 1 weiblich (Gülsen E. Reinigungskraft B)"
+ "Vignette 1 weiblich (Gülsen E. Reinigungskraft B)"
- "Vignette 2 weiblich (Gülsen E. Anwältin B)"
+ "Vignette 2 weiblich (Gülsen E. Anwältin B)"
"Vignette 3 weiblich (Monika E. Reinigungskraft B)"
- "Vignette 4 weiblich (Monika E. Anwältin B)"
+ "Vignette 4 weiblich (Monika E. Anwältin B)"
- "Vignette 5 männlich (Hasan E. Reinigungskraft B)"
+ "Vignette 5 männlich (Hasan E. Reinigungskraft B)"
- "Vignette 6 männlich (Hasan E. Anwalt B)"
+ "Vignette 6 männlich (Hasan E. Anwalt B)"
- "Vignette 7 männlich (Martin E. Reinigungskraft B)"
+ "Vignette 7 männlich (Martin E. Reinigungskraft B)"
- "Vignette 8 männlich (Martin E. Anwalt B)"
+ "Vignette 8 männlich (Martin E. Anwalt B)"
- "Vignette 9 weiblich (Gülsen E. Reinigungskraft E)"
+ "Vignette 9 weiblich (Gülsen E. Reinigungskraft E)"
- "Vignette 10 weiblich (Gülsen E. Anwältin E)"
+ "Vignette 10 weiblich (Gülsen E. Anwältin E)"
"Vignette 11 weiblich (Monika E. Reinigungskraft E)"
- "Vignette 12 weiblich (Monika E. Anwältin E)"
+ "Vignette 12 weiblich (Monika E. Anwältin E)"
- "Vignette 13 männlich (Hasan E. Reinigungskraft E)"
+ "Vignette 13 männlich (Hasan E. Reinigungskraft E)"
- "Vignette 14 männlich (Hasan E. Anwalt E)"
+ "Vignette 14 männlich (Hasan E. Anwalt E)"
- "Vignette 15 männlich (Martin E. Reinigungskraft E)"
+ "Vignette 15 männlich (Martin E. Reinigungskraft E)"
- "Vignette 16 männlich (Martin E. Anwalt E)"
+ "Vignette 16 männlich (Martin E. Anwalt E)"
"99"
Backtrace:
x
1. \-withr::with_tempfile(...) at test-data_read.R:275:3
2. \-base::eval(substitute(code), envir = env)
3. \-base::eval(substitute(code), envir = env)
4. \-testthat::expect_identical(...) at test-data_read.R:348:5
-- Failure ('test-data_read.R:378:5'): data_read, convert many labels correctly --
attributes(d$c12c)$labels (`actual`) not identical to c(...) (`expected`).
names(actual) | names(expected)
[10] "8" | "8" [10]
[11] "9" | "9" [11]
[12] "10 = sehr starke" | "10 = sehr starke" [12]
[13] "weiß nicht / keine Angabe" - "weiß nicht / keine Angabe" [13]
Backtrace:
x
1. \-withr::with_tempfile(...) at test-data_read.R:275:3
2. \-base::eval(substitute(code), envir = env)
3. \-base::eval(substitute(code), envir = env)
4. \-testthat::expect_identical(...) at test-data_read.R:378:5
[ FAIL 2 | WARN 0 | SKIP 3 | PASS [201](https://github.com/easystats/datawizard/actions/runs/9145947600/job/25145489411?pr=504#step:7:203)4 ]
Error: Error: Test failures
Execution halted
Error: Error: R CMD check found ERRORs
Execution halted
1 error x | 0 warnings v | 1 note x |
I'll take a look but we only use reading functions from other packages so maybe the error originates in one of them. If so I'll report it to them |
Sounds good. And thanks for cleaning the lints! 🧹 |
This one is new and shouldn't be related to any changes from us / in our packages. |
@IndrajeetPatil Do we need the favicons for all our packages now? |
@strengejacke No, this is just a bandaid. The issue should be fixed soon upstream in pkgdown. I am switching to CRAN version of pkgdown until this is resolved. |
I'm very confused about this. I can reproduce on Windows with R 4.1.3 when I run the Also, we use |
I also can't find any relevant changes to |
Only thing I can think of is a change in the CI because of changes in |
Actually we started testing on Windows with R 4.1 very recently: easystats/workflows@54e0487 This might have been broken for a while |
We added that test over a year ago (fe74c96#diff-6529e485b0d7b1e2df1af2fc885a3dbbb0fcec8eacaff61963679ffd7df001d6), it should have occurred on the "old-R" tests back than. |
Close #265