Clean lints in utils.R #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #342 +/- ##
==========================================
- Coverage 30.84% 30.74% -0.10%
==========================================
Files 8 8
Lines 308 309 +1
==========================================
Hits 95 95
- Misses 213 214 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This reverts commit cb4c0ff.
strengejacke
reviewed
Jan 4, 2023
R/utils.R
Outdated
| @@ -13,12 +13,12 @@ | |||
| cran_version <- lapply(pkgs[pkg_deps, "Version"], package_version) | |||
| local_version <- lapply(pkg_deps, utils::packageVersion) | |||
|
|
|||
| behind <- mapply(">", cran_version, local_version) | |||
| behind <- Map(">", cran_version, local_version) | |||
There was a problem hiding this comment.
Does Map() return a vector or a list by default?
There was a problem hiding this comment.
Yes, it always returns a list, and doesn't try to simplify the results.
There was a problem hiding this comment.
But mapply() returns a vector, no? So I'm not sure you need to unlist here.
strengejacke
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#334