Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename group/group_by arguments into by #872

Merged
merged 7 commits into from
May 16, 2024
Merged

Rename group/group_by arguments into by #872

merged 7 commits into from
May 16, 2024

Conversation

strengejacke
Copy link
Member

@strengejacke strengejacke commented May 16, 2024 •
edited
Loading

@strengejacke strengejacke mentioned this pull request May 16, 2024
Closed
10 tasks
@strengejacke strengejacke changed the title https://github.com/easystats/easystats/issues/404 Rename group/group_by arguments into by May 16, 2024
@DominiqueMakowski
Copy link
Member

there's also get_datagrid()

@strengejacke
Copy link
Member Author

there's also get_datagrid()

Ok, so at would be renamed, too? Probably makes sense to have as few different argument names across easystats as possible.

@strengejacke strengejacke merged commit 849db1e into main May 16, 2024
16 of 27 checks passed
@strengejacke strengejacke deleted the rename_group_by branch May 16, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@strengejacke @DominiqueMakowski