Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: check_sphericity() #551

Closed
DominiqueMakowski opened this issue Feb 26, 2023 · 5 comments
Closed

docs: check_sphericity() #551

DominiqueMakowski opened this issue Feb 26, 2023 · 5 comments
Labels
docs 📚 Something to be adressed in docs and/or vignettes

Comments

@DominiqueMakowski
Copy link
Member

image

I was looking for the easystats wrapper for sphericity test for correlation matrices, stumbled on this, and then was like wait a second it doesn't work for correlation matrices. After digging up I remembered that it the other test is implemented in check_sphericity_bartlett, and not mentioned from each others docs. Should we unify this by merging the two tests generic functions? Or at least mention and document a bit better

@mattansb
Copy link
Member

I don't think they should be merged - they have different purposes.

But perhaps we can link to one another right under of the title. Something along the lines "for Bartlett's test of sphericity see..."

@DominiqueMakowski
Copy link
Member Author

I'll open a PR

@strengejacke strengejacke added the docs 📚 Something to be adressed in docs and/or vignettes label Feb 26, 2023
@strengejacke
Copy link
Member

bump

@DominiqueMakowski
Copy link
Member Author

it has been merged no?

@strengejacke
Copy link
Member

ah, ok. so why is this still open? :curious

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs 📚 Something to be adressed in docs and/or vignettes
Projects
None yet
Development

No branches or pull requests

3 participants