New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace these two lines #63

Closed

strengejacke opened this issue Feb 9, 2020 · 2 comments

Assignees

Member

strengejacke commented Feb 9, 2020

@strengejacke since you're an expert of that, could you give me a hand to replace these two lines 😁

report/R/report.data.frame.R

Lines 118 to 119 in 71b6ed0

    
           groups <- dplyr::group_vars(model) 
        
           ungrouped_x <- dplyr::ungroup(model)

So we can remove the dplyr dep? Thanks 🥇

Originally posted by @DominiqueMakowski in #50 (comment)

Member Author

strengejacke commented Feb 9, 2020

reminder:

https://github.com/easystats/effectsize/blob/556b596de29deffd2254ce0f2be2133cbb1eac64/R/change_scale.R

https://github.com/easystats/effectsize/blob/0f02ac19c741ea9d28bb7f5121fda24479f47104/R/standardize.data.frame.R

https://github.com/easystats/effectsize/blob/e8a1c26aaea004aa1bad1c5bcd4d54eac1ac78f0/R/normalize.R

strengejacke self-assigned this

strengejacke mentioned this issue

get rid of dplyr #39

Closed

Member Author

strengejacke commented Feb 11, 2020

https://github.com/strengejacke/sjmisc/blob/master/R/reshape_helpers.R#L65

strengejacke closed this as completed in

cb148b4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment