Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of dplyr #39

Closed
strengejacke opened this issue Aug 15, 2019 · 5 comments
Closed

get rid of dplyr #39

strengejacke opened this issue Aug 15, 2019 · 5 comments

Comments

@strengejacke
Copy link
Member

I think we should avoid using dplyr in report, and looking at the code, I think this is easy to do. I can work on report.data.frame()...
strengejacke added a commit that referenced this issue Aug 15, 2019
@strengejacke
#39 (use own column-order function)
9cc8c17
strengejacke added a commit that referenced this issue Aug 15, 2019
@strengejacke
#39
68d4e55
strengejacke added a commit that referenced this issue Aug 15, 2019
@strengejacke
#39 (use own remove-function)
d8212bc
@DominiqueMakowski
Copy link
Member

If I recall correctly, the main blocker for that was report.grouped_df

@strengejacke
Copy link
Member Author

Probably, but we also have advanced our R skills the past months, so... 💪

@DominiqueMakowski
Copy link
Member

true dat 🚀

@strengejacke
Copy link
Member Author

strengejacke commented Aug 15, 2019 •
edited

I think behaviour has changed since dplyr 0.8.0, which was released mid of Feb 19. We can recycle this code here to manage grouped df's: https://github.com/strengejacke/sjmisc/blob/master/R/reshape_helpers.R#L65

@strengejacke
Copy link
Member Author

closing in favor of #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DominiqueMakowski @strengejacke