-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicated text #280
Fix duplicated text #280
Conversation
R/report.lm.R
Outdated
info <- report_info(x, effectsize = attributes(params)$effectsize, parameters = params, ...) | ||
model <- report_model(x, table = table, ...) | ||
perf <- report_performance(x, table = table, ...) | ||
intercept <- report_intercept(x, table = table, ...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure we can remove the dots here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah no, my bad, I removed them when I ran the code line by line. I'll clean this tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@etiennebacher Do you also want to update the snapshots? |
yes I can do that |
Only Windows-specific snapshots were updated, but macOS builds still continue to succeed. How is that possible?! 🤔 |
We can figure it out later. |
Close #279. If ok, we need to update the snapshots in the tests.
Changes: collapse predictors names and the intercept values in the first paragraph.
New output:
Created on 2022-09-01 by the reprex package (v2.0.1)