-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The extremest edge case: homebridge-p1
crashes when gas meter is removed
#78
Comments
I don’t see a crash, just a warning message (with stack trace)? Indeed, removing a meter isn’t a use case I had anticipated, but it’s quite easy to prevent the TypeError. BTW you’re running an old beta version of Homebridge P1. |
Yes, I am, because almost every release you make bumps the minimum On that subject: this plugin is "homebridge verified", but per https://github.com/homebridge/verified#requirements, that means:
AFAICT that means that anything other than |
I develop and test my plugins against the latest LTS version of NodeJS. Other versions might work, or not. I simply don't have the bandwidth to test these. Usually a NodeJS release includes security updates, so I would recommend to update NodeJS to the latest version. |
Bug fix: TypeError when telegram structure changes (e.g. when removing a meter), see #78.
Updated to Thanks for https://github.com/ebaauw/homebridge-p1/releases/tag/v1.3.10! 🤩 I think this issue can be closed? 😊 Unfortunately I won't be able to re-test this, because I don't have a single meter left 😇 |
Yesterday, my gas meter was removed. I realize this is a pretty extreme edge case 🤓 😅
But this did trigger this plugin crashing:
A simple reboot fixes it though:
The text was updated successfully, but these errors were encountered: